git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t4014: shell portability fix

From
Jeff King <peff@peff.net>
Date
Jun 1, 2016, 16:58 UTC
Message-ID
<20160601165843.GA11464@sigill.intra.peff.net>
In-Reply-To
<xmqqfuswzw2l.fsf@gitster.mtv.corp.google.com>
On Wed, Jun 01, 2016 at 09:57:06AM -0700, Junio C Hamano wrote:
Show 22 quoted lines
> Jeff King <peff@peff.net> writes:
> 
> > Maybe:
> >
> >     We sometimes get around this by using env, like:
> >
> >       test_must_fail env FOO=BAR some-program
> >
> >     But that works for test_must_fail because it further runs its
> >     arguments via the shell, so we can stick the "env" on the right-hand
> >     side of the function. It would not work to do:
> >
> >       env FOO=BAR test_must_fail some-program
> >
> >     because env does not know about our shell functions...
> >
> > is more clear?
> 
> I don't know.  What I wanted to say was that "test_must_fail env"
> pattern works _only_ when some-program is not a shell function, even
> though "test_must_fail some-program" itself without env is OK when
> some-program is a shell function.

Right, but I think that is taking it to a meta-level. We are already talking about one shell function, test_must_fail versus test_commit. Introducing another one in the test_must_fail to the right of "env" obviously does not work, but that is independent of whether test_must_fail is in use.

-Peff
Previous: Junio C HamanoNext: Johannes Sixt
Message 16 of 20 in “t4014: shell portability fix”
  1. t4014: shell portability fixJunio C Hamano, May 31, 2016
  2. Jeff KingMay 31, 2016
  3. Eric SunshineJun 1, 2016
  4. Jeff KingJun 1, 2016
  5. Jeff KingJun 1, 2016
  6. Jeff KingJun 1, 2016
  7. Jeff KingJun 1, 2016
  8. Jeff KingJun 1, 2016
  9. Jeff KingJun 1, 2016
  10. Junio C HamanoJun 1, 2016
  11. Junio C HamanoJun 1, 2016
  12. Jeff KingJun 1, 2016
  13. Junio C HamanoJun 1, 2016
  14. Jeff KingJun 1, 2016
  15. Junio C HamanoJun 1, 2016
  16. Jeff KingJun 1, 2016
  17. Johannes SixtJun 1, 2016
  18. Jeff KingJun 1, 2016
  19. Eric SunshineJun 1, 2016
  20. Ramsay JonesJun 1, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.