git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t4014: shell portability fix

From
Junio C Hamano <gitster@pobox.com>
Date
May 31, 2016, 22:53 UTC
Message-ID
<xmqqbn3l3kmc.fsf@gitster.mtv.corp.google.com>
One-shot assignment to an environment variable, i.e.
	VAR=VAL cmd

does not work as expected for "cmd" that is a shell function on certain shells. test_commit _is_ a helper function and cannot be driven that way portably.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 t/t4014-format-patch.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh
index 8049cad..c3aa543 100755
--- a/t/t4014-format-patch.sh
+++ b/t/t4014-format-patch.sh
@@ -1072,7 +1072,7 @@ test_expect_success '--from omits redundant in-body header' '
 '
 
 test_expect_success 'in-body headers trigger content encoding' '
-	GIT_AUTHOR_NAME="éxötìc" test_commit exotic &&
+	(export GIT_AUTHOR_NAME="éxötìc"; test_commit exotic) &&
 	test_when_finished "git reset --hard HEAD^" &&
 	git format-patch -1 --stdout --from >patch &&
 	cat >expect <<-\EOF &&
Next: Jeff King
Message 1 of 20 in “t4014: shell portability fix”
  1. t4014: shell portability fixJunio C Hamano, May 31, 2016
  2. Jeff KingMay 31, 2016
  3. Eric SunshineJun 1, 2016
  4. Jeff KingJun 1, 2016
  5. Jeff KingJun 1, 2016
  6. Jeff KingJun 1, 2016
  7. Jeff KingJun 1, 2016
  8. Jeff KingJun 1, 2016
  9. Jeff KingJun 1, 2016
  10. Junio C HamanoJun 1, 2016
  11. Junio C HamanoJun 1, 2016
  12. Jeff KingJun 1, 2016
  13. Junio C HamanoJun 1, 2016
  14. Jeff KingJun 1, 2016
  15. Junio C HamanoJun 1, 2016
  16. Jeff KingJun 1, 2016
  17. Johannes SixtJun 1, 2016
  18. Jeff KingJun 1, 2016
  19. Eric SunshineJun 1, 2016
  20. Ramsay JonesJun 1, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.