Re: [PATCH] t4014: shell portability fix

From: Jeff King <peff@peff.net>
Date: May 31, 2016, 22:56 UTC
Message-ID: <20160531225628.GA4585@sigill.intra.peff.net>
In-Reply-To: <xmqqbn3l3kmc.fsf@gitster.mtv.corp.google.com>

On Tue, May 31, 2016 at 03:53:15PM -0700, Junio C Hamano wrote:

Show 23 quoted lines

> One-shot assignment to an environment variable, i.e.
> 
> 	VAR=VAL cmd
> 
> does not work as expected for "cmd" that is a shell function on
> certain shells.  test_commit _is_ a helper function and cannot be
> driven that way portably.
> 
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
>  t/t4014-format-patch.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh
> index 8049cad..c3aa543 100755
> --- a/t/t4014-format-patch.sh
> +++ b/t/t4014-format-patch.sh
> @@ -1072,7 +1072,7 @@ test_expect_success '--from omits redundant in-body header' '
>  '
>  
>  test_expect_success 'in-body headers trigger content encoding' '
> -	GIT_AUTHOR_NAME="éxötìc" test_commit exotic &&
> +	(export GIT_AUTHOR_NAME="éxötìc"; test_commit exotic) &&

Thanks. This one is my fault. There's another use of the same name elsewhere, but it's to call "git commit" directly, so it's OK.

-Peff

PS I really hate this particular shell behavior, as it means that your
   code can break because somebody _else_ decides to replace the command
   you are calling with a function.  But I guess we are stuck with it.