Re: [PATCH v5 1/5] eoie: add End of Index Entry (EOIE) extension

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 17, 2018, 19:08 UTC
Message-ID: <xmqqfty86iwv.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CACsJy8CqaEGDaEAgp1EspR+BwyHB6YSPoppZ2t5M+qxg77hULg@mail.gmail.com>

Duy Nguyen <pclouds@gmail.com> writes:

Show 5 quoted lines

> I get annoyed by the "ignoring unknown extension xxx" messages while
> testing though (not just this extension) and I think it will be the
> same for other git implementations. But perhaps other implementations
> just silently drop the extension. Most of the extensions we have added
> so far (except the ancient 'TREE') are optional and are probably not

Most of the index extensions are optional, including TREE. I think "link" is the only one that the readers that do not understand it are told to abort without causing damage.

> present 99% of time when a different git impl reads an index created
> by C Git. This 'EIOE' may be a good test then to see if they follow
> the "ignore optional extensions" rule since it will always appear in
> new C Git releases.

I think we probably should squelch "ignoring unknown" unless some sort of GIT_TRACE/DEBUG switch is set.

Patches welcome ;-)

Thanks.