Re: [PATCH 2/3] ieot: default to not writing IEOT section

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Nov 13, 2018, 18:18 UTC
Message-ID: <20181113181855.GB68106@google.com>
In-Reply-To: <f2f8cec8-d770-a1e9-b5a1-83653575122e@gmail.com>

Hi,

Ben Peart wrote:

> On 11/12/2018 7:39 PM, Jonathan Nieder wrote:

Show 10 quoted lines

>> As with EOIE, popular versions of Git do not support the new IEOT
>> extension yet.  When accessing a Git repository written by a more
>> modern version of Git, they correctly ignore the unrecognized section,
>> but in the process they loudly warn
>>
>> 	ignoring IEOT extension
>>
>> resulting in confusion for users.  Introduce the index extension more
>> gently by not writing it yet in this first version with support for
>> it.

[...]

Show 7 quoted lines

>> Introduce a '[index] recordOffsetTable' configuration variable to
>> control whether the new index extension is written.
>
> Why introduce a new setting to disable writing the IEOT extension instead of
> just using the existing index.threads setting?  If index.threads=1 then the
> IEOT extension isn't written which (I believe) will accomplish the same
> goal.

Do you mean defaulting to index.threads=1? I don't think that would be a good default, but if you have a different change in mind then I'd be happy to hear it.

Or do you mean that if the user has explicitly specified index.threads=true, then that should imply index.recordOffsetTable=true so users only have to set one setting to turn it on? I can imagine that working well.

Thanks, Jonathan