git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/5] eoie: default to not writing EOIE section

From
SZEDER Gábor <szeder.dev@gmail.com>
Date
Nov 20, 2018, 13:21 UTC
Message-ID
<20181120132151.GA30222@szeder.dev>
In-Reply-To
<efa1d7fb-1da3-c093-1cb1-873a2e1c445c@gmail.com>
On Tue, Nov 20, 2018 at 08:06:16AM -0500, Ben Peart wrote:
Show 13 quoted lines
> >diff --git a/read-cache.c b/read-cache.c
> >index 4ca81286c0..1e9c772603 100644
> >--- a/read-cache.c
> >+++ b/read-cache.c
> >@@ -2689,6 +2689,15 @@ void update_index_if_able(struct index_state *istate, struct lock_file *lockfile
> >  		rollback_lock_file(lockfile);
> >  }
> >+static int record_eoie(void)
> >+{
> >+	int val;
> 
> I believe you are going to want to initialize val to 0 here as it is on the
> stack so is not guaranteed to be zero.
The git_config_get_bool() call below will initialize it anyway.
Show 5 quoted lines
> >+
> >+	if (!git_config_get_bool("index.recordendofindexentries", &val))
> >+		return val;
> >+	return 0;
> >+}
Previous: Ben PeartNext: Jeff King
Message 168 of 199 in “read-cache: speed up index load through parallelization”
  1. read-cache: speed up index load through parallelizationBen Peart, Aug 23, 2018
  2. Stefan BellerAug 23, 2018
  3. Ben PeartAug 23, 2018
  4. Duy NguyenAug 24, 2018
  5. Ben PeartAug 28, 2018
  6. Junio C HamanoAug 23, 2018
  7. Ben PeartAug 23, 2018
  8. Duy NguyenAug 24, 2018
  9. Duy NguyenAug 24, 2018
  10. Ben PeartAug 24, 2018
  11. read-cache.c: optimize reading index format v4Nguyễn Thái Ngọc Duy, Aug 25, 2018
  12. Junio C HamanoAug 27, 2018
  13. Duy NguyenAug 28, 2018
  14. Ben PeartAug 28, 2018
  15. Junio C HamanoAug 29, 2018
  16. Duy NguyenSep 4, 2018
  17. 0/1 optimize reading index format v4Nguyễn Thái Ngọc Duy, Sep 2, 2018
  18. 1/1 read-cache.c: optimize reading index format v4Nguyễn Thái Ngọc Duy, Sep 2, 2018
  19. Junio C HamanoSep 4, 2018
  20. Junio C HamanoSep 4, 2018
  21. Duy NguyenAug 24, 2018
  22. Ben PeartAug 24, 2018
  23. Duy NguyenAug 24, 2018
  24. Ben PeartAug 24, 2018
  25. 0/3 read-cache: speed up index load through parallelizationBen Peart, Aug 29, 2018
  26. 2/3 read-cache: load cache extensions on worker threadBen Peart, Aug 29, 2018
  27. Junio C HamanoAug 29, 2018
  28. Ben PeartAug 29, 2018
  29. Junio C HamanoAug 29, 2018
  30. Duy NguyenSep 3, 2018
  31. Duy NguyenSep 3, 2018
  32. 3/3 read-cache: micro-optimize expand_name_field() to speed up V4 index parsing.Ben Peart, Aug 29, 2018
  33. 1/3 read-cache: speed up index load through parallelizationBen Peart, Aug 29, 2018
  34. Junio C HamanoAug 29, 2018
  35. Ben PeartAug 29, 2018
  36. Duy NguyenSep 3, 2018
  37. 0/4 read-cache: speed up index load through parallelizationBen Peart, Sep 6, 2018
  38. 1/4 read-cache: optimize expand_name_field() to speed up V4 index parsing.Ben Peart, Sep 6, 2018
  39. 2/4 eoie: add End of Index Entry (EOIE) extensionBen Peart, Sep 6, 2018
  40. Junio C HamanoSep 7, 2018
  41. Ben PeartSep 7, 2018
  42. Martin ÅgrenSep 8, 2018
  43. Ben PeartSep 8, 2018
  44. Martin ÅgrenSep 8, 2018
  45. 3/4 read-cache: load cache extensions on a worker threadBen Peart, Sep 6, 2018
  46. Junio C HamanoSep 7, 2018
  47. Ben PeartSep 8, 2018
  48. 4/4 read-cache: speed up index load through parallelizationBen Peart, Sep 6, 2018
  49. Torsten BögershausenSep 7, 2018
  50. Ben PeartSep 7, 2018
  51. Junio C HamanoSep 7, 2018
  52. Ben PeartSep 7, 2018
  53. Duy NguyenSep 8, 2018
  54. 0/5 read-cache: speed up index load through parallelizationBen Peart, Sep 11, 2018
  55. 1/5 eoie: add End of Index Entry (EOIE) extensionBen Peart, Sep 11, 2018
  56. 2/5 read-cache: load cache extensions on a worker threadBen Peart, Sep 11, 2018
  57. 3/5 read-cache: speed up index load through parallelizationBen Peart, Sep 11, 2018
  58. 4/5 read-cache.c: optimize reading index format v4Ben Peart, Sep 11, 2018
  59. 5/5 read-cache: clean up casting and byte decodingBen Peart, Sep 11, 2018
  60. Ben PeartSep 12, 2018
  61. 0/5 read-cache: speed up index load through parallelizationBen Peart, Sep 12, 2018
  62. 2/5 read-cache: load cache extensions on a worker threadBen Peart, Sep 12, 2018
  63. Duy NguyenSep 15, 2018
  64. Duy NguyenSep 15, 2018
  65. Ben PeartSep 17, 2018
  66. Duy NguyenSep 15, 2018
  67. Junio C HamanoSep 17, 2018
  68. Ben PeartSep 17, 2018
  69. Duy NguyenSep 17, 2018
  70. Junio C HamanoSep 17, 2018
  71. 3/5 read-cache: load cache entries on worker threadsBen Peart, Sep 12, 2018
  72. Duy NguyenSep 15, 2018
  73. Ben PeartSep 17, 2018
  74. Duy NguyenSep 15, 2018
  75. Duy NguyenSep 15, 2018
  76. Ben PeartSep 17, 2018
  77. Duy NguyenSep 15, 2018
  78. 4/5 read-cache.c: optimize reading index format v4Ben Peart, Sep 12, 2018
  79. 5/5 read-cache: clean up casting and byte decodingBen Peart, Sep 12, 2018
  80. 1/5 eoie: add End of Index Entry (EOIE) extensionBen Peart, Sep 12, 2018
  81. Junio C HamanoSep 13, 2018
  82. Duy NguyenSep 15, 2018
  83. Ben PeartSep 17, 2018
  84. Duy NguyenSep 17, 2018
  85. Junio C HamanoSep 17, 2018
  86. Duy NguyenSep 17, 2018
  87. Junio C HamanoSep 17, 2018
  88. 0/7 speed up index load through parallelizationBen Peart, Sep 26, 2018
  89. 1/7 read-cache.c: optimize reading index format v4Ben Peart, Sep 26, 2018
  90. 2/7 read-cache: clean up casting and byte decodingBen Peart, Sep 26, 2018
  91. 3/7 eoie: add End of Index Entry (EOIE) extensionBen Peart, Sep 26, 2018
  92. SZEDER GáborSep 28, 2018
  93. Ben PeartSep 28, 2018
  94. SZEDER GáborSep 29, 2018
  95. Duy NguyenSep 29, 2018
  96. Junio C HamanoSep 29, 2018
  97. 4/7 config: add new index.threads config settingBen Peart, Sep 26, 2018
  98. SZEDER GáborSep 28, 2018
  99. Ben PeartSep 28, 2018
  100. Junio C HamanoSep 28, 2018
  101. Ben PeartSep 28, 2018
  102. Ramsay JonesSep 28, 2018
  103. Junio C HamanoSep 28, 2018
  104. Ben PeartOct 1, 2018
  105. SZEDER GáborOct 1, 2018
  106. 5/7 read-cache: load cache extensions on a worker threadBen Peart, Sep 26, 2018
  107. 6/7 ieot: add Index Entry Offset Table (IEOT) extensionBen Peart, Sep 26, 2018
  108. 7/7 read-cache: load cache entries on worker threadsBen Peart, Sep 26, 2018
  109. Junio C HamanoSep 26, 2018
  110. Duy NguyenSep 27, 2018
  111. 0/7 speed up index load through parallelizationBen Peart, Oct 1, 2018
  112. 1/7 read-cache.c: optimize reading index format v4Ben Peart, Oct 1, 2018
  113. 2/7 read-cache: clean up casting and byte decodingBen Peart, Oct 1, 2018
  114. Duy NguyenOct 1, 2018
  115. 3/7 eoie: add End of Index Entry (EOIE) extensionBen Peart, Oct 1, 2018
  116. SZEDER GáborOct 1, 2018
  117. Ben PeartOct 2, 2018
  118. Duy NguyenOct 1, 2018
  119. Ben PeartOct 2, 2018
  120. 4/7 config: add new index.threads config settingBen Peart, Oct 1, 2018
  121. 5/7 read-cache: load cache extensions on a worker threadBen Peart, Oct 1, 2018
  122. Duy NguyenOct 1, 2018
  123. Ben PeartOct 2, 2018
  124. 6/7 ieot: add Index Entry Offset Table (IEOT) extensionBen Peart, Oct 1, 2018
  125. Duy NguyenOct 1, 2018
  126. Ben PeartOct 2, 2018
  127. Duy NguyenOct 2, 2018
  128. 7/7 read-cache: load cache entries on worker threadsBen Peart, Oct 1, 2018
  129. Duy NguyenOct 1, 2018
  130. Ben PeartOct 2, 2018
  131. 0/7 speed up index load through parallelizationBen Peart, Oct 10, 2018
  132. 1/7 read-cache.c: optimize reading index format v4Ben Peart, Oct 10, 2018
  133. 2/7 read-cache: clean up casting and byte decodingBen Peart, Oct 10, 2018
  134. 3/7 eoie: add End of Index Entry (EOIE) extensionBen Peart, Oct 10, 2018
  135. 4/7 config: add new index.threads config settingBen Peart, Oct 10, 2018
  136. 5/7 read-cache: load cache extensions on a worker threadBen Peart, Oct 10, 2018
  137. 6/7 ieot: add Index Entry Offset Table (IEOT) extensionBen Peart, Oct 10, 2018
  138. 7/7 read-cache: load cache entries on worker threadsBen Peart, Oct 10, 2018
  139. Jeff KingOct 19, 2018
  140. Junio C HamanoOct 22, 2018
  141. Ben PeartOct 22, 2018
  142. Junio C HamanoOct 12, 2018
  143. Duy NguyenOct 14, 2018
  144. Ben PeartOct 15, 2018
  145. 0/3 Avoid confusing messages from new index extensions (Re: [PATCH v8 0/7] speed up index load through parallelization)Jonathan Nieder, Nov 13, 2018
  146. 1/3 eoie: default to not writing EOIE sectionJonathan Nieder, Nov 13, 2018
  147. Junio C HamanoNov 13, 2018
  148. Ben PeartNov 13, 2018
  149. Jonathan NiederNov 13, 2018
  150. Junio C HamanoNov 14, 2018
  151. Jonathan NiederNov 15, 2018
  152. 2/3 ieot: default to not writing IEOT sectionJonathan Nieder, Nov 13, 2018
  153. Jonathan TanNov 13, 2018
  154. Junio C HamanoNov 13, 2018
  155. Jonathan NiederNov 13, 2018
  156. Duy NguyenNov 13, 2018
  157. Jonathan NiederNov 13, 2018
  158. Ben PeartNov 13, 2018
  159. Jonathan NiederNov 13, 2018
  160. Ben PeartNov 13, 2018
  161. Jonathan NiederNov 13, 2018
  162. Ben PeartNov 14, 2018
  163. Jonathan NiederNov 15, 2018
  164. Junio C HamanoNov 14, 2018
  165. 0/5 Avoid confusing messages from new index extensionsJonathan Nieder, Nov 20, 2018
  166. 1/5 eoie: default to not writing EOIE sectionJonathan Nieder, Nov 20, 2018
  167. Ben PeartNov 20, 2018
  168. SZEDER GáborNov 20, 2018
  169. Jeff KingNov 21, 2018
  170. Junio C HamanoNov 22, 2018
  171. Ben PeartNov 20, 2018
  172. 2/5 ieot: default to not writing IEOT sectionJonathan Nieder, Nov 20, 2018
  173. Ben PeartNov 20, 2018
  174. Stefan BellerNov 26, 2018
  175. Ben PeartNov 26, 2018
  176. Stefan BellerNov 26, 2018
  177. Junio C HamanoNov 27, 2018
  178. 3/5 index: do not warn about unrecognized extensionsJonathan Nieder, Nov 20, 2018
  179. 4/5 index: make index.threads=true enable ieot and eoieJonathan Nieder, Nov 20, 2018
  180. Ben PeartNov 20, 2018
  181. 5/5 index: offer advice for unknown index extensionsJonathan Nieder, Nov 20, 2018
  182. Ævar Arnfjörð BjarmasonNov 20, 2018
  183. Ben PeartNov 20, 2018
  184. Junio C HamanoNov 21, 2018
  185. Jonathan NiederNov 21, 2018
  186. Jonathan NiederNov 21, 2018
  187. Junio C HamanoNov 21, 2018
  188. Jonathan NiederNov 21, 2018
  189. Junio C HamanoNov 21, 2018
  190. Junio C HamanoNov 21, 2018
  191. Jonathan NiederNov 21, 2018
  192. Junio C HamanoNov 21, 2018
  193. Jonathan NiederNov 21, 2018
  194. Ævar Arnfjörð BjarmasonNov 21, 2018
  195. 3/3 index: do not warn about unrecognized extensionsJonathan Nieder, Nov 13, 2018
  196. Junio C HamanoNov 13, 2018
  197. Ben PeartNov 13, 2018
  198. Junio C HamanoNov 14, 2018
  199. Ben PeartNov 14, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.