Re: [PATCH 2/3] ieot: default to not writing IEOT section

From: Duy Nguyen <pclouds@gmail.com>
Date: Nov 13, 2018, 15:37 UTC
Message-ID: <CACsJy8DNo1Q96jb5nwJ8vREFu=ZmbN29+uoH17N2VVy80k387Q@mail.gmail.com>
In-Reply-To: <20181113011207.GE170017@google.com>

On Tue, Nov 13, 2018 at 2:12 AM Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 16 quoted lines

>
> Junio C Hamano wrote:
>
> > How about
> >
> >       hint: ignoring an optional IEOT extension
> >
> > to make it clear that it is totally harmless?
> >
> > With that, we can add advise.unknownIndexExtension=false to turn all
> > of them off with a single switch.
>
> I like it.  Expect a patch soon (tonight or tomorrow) that does that.
>
> We'll have to find some appropriate place in the documentation to
> explain what the message is about, still.

Also from the last discussion, if I remember correctly, this "ignoring" is considered harmless and could be suppressed most of the time. But commands like 'fsck' should always report it.

-- 
Duy