Re: [PATCH v1] read-cache: speed up index load through parallelization
- From
Ben Peart <peartben@gmail.com>
- Date
- Aug 28, 2018, 14:53 UTC
- Message-ID
- <00c3b1de-4fcf-ba03-0f8d-9ea2540ba657@gmail.com>
- In-Reply-To
- <CACsJy8Cnxz0w0g53Gb=_iXEdbSUFgssTozfxea0H52mWJ-RmTg@mail.gmail.com>
On 8/24/2018 2:40 PM, Duy Nguyen wrote:
Show 18 quoted lines
> On Thu, Aug 23, 2018 at 7:33 PM Stefan Beller <sbeller@google.com> wrote: >>> +core.fastIndex:: >>> + Enable parallel index loading >>> ++ >>> +This can speed up operations like 'git diff' and 'git status' especially >>> +when the index is very large. When enabled, Git will do the index >>> +loading from the on disk format to the in-memory format in parallel. >>> +Defaults to true. >> "fast" is a non-descriptive word as we try to be fast in any operation? >> Maybe core.parallelIndexReading as that just describes what it >> turns on/off, without second guessing its effects? > Another option is index.threads (the "index" section currently only > has one item, index.version). The value could be the same as > grep.threads or pack.threads. > > (and if you're thinking about parallelizing write as well but it > should be tuned differently, then perhaps index.readThreads, but I > don't think we need to go that far)
I like that. I'll switch to index.threads and make 'true' or '0' mean "automatically determine the number of threads to use" similar to pack.threads.