Re: [PATCH 1/4] repack: convert "names" util bitfield to array

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 21, 2022, 23:35 UTC
Message-ID: <xmqqfsfgiwcq.fsf@gitster.g>
In-Reply-To: <Y1MrXoobkVKngYL1@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> Yeah, I actually considered writing it that way, but it felt a bit silly
> to use _ARRAY for something which is clearly meant to be a single item.

You are not alone. I updated Réne's coccinelle rules to refrain from converting xcalloc() to CALLOC_ARRAY() for a single element case exactly because it feels silly to use array function for a singleton with 1c57cc70 (cocci: allow xcalloc(1, size), 2021-03-15).

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.