Re: [PATCH v2 4/5] repack: use tempfiles for signal cleanup

From: Jeff King <peff@peff.net>
Date: Oct 23, 2022, 20:55 UTC
Message-ID: <Y1WqX7YRrSpkmyxH@coredump.intra.peff.net>
In-Reply-To: <xmqqlep6fm5h.fsf@gitster.g>

On Sun, Oct 23, 2022 at 11:08:26AM -0700, Junio C Hamano wrote:

Show 10 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > Here's a patch on top of of jk/repack-tempfile-cleanup that adjusts the
> > test (and should make the immediate racy CI pain go away). It gives some
> > explanation why the third option isn't as interesting as you'd think. If
> > somebody later wants to add such a "pack-objects died" error, we can
> > adjust sigpipe handling there.
> 
> An extremely simplified alternative would be just to say !  instead
> of test_must_fail, which essentially is ok=anycrash ;-)

I would have been tempted to do that if we hadn't already added ok=sigpipe long ago. :)

> I did try the same exact patch before going to bed last night but
> t7700 somehow failed some other steps in my local tests and I gave
> up digging further X-<.  One step at a time...

Hopefully not my bits. :) FWIW, the tips of "master", "next", and "seen" all pass just fine for me (minus this race on seen).

-Peff