Re: [PATCH 1/4] repack: convert "names" util bitfield to array

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 21, 2022, 23:51 UTC
Message-ID: <xmqq8rl8ivlb.fsf@gitster.g>
In-Reply-To: <Y1MumtN5fcCGD5+G@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 15 quoted lines

> On Fri, Oct 21, 2022 at 04:35:17PM -0700, Junio C Hamano wrote:
>
>> Jeff King <peff@peff.net> writes:
>> 
>> > Yeah, I actually considered writing it that way, but it felt a bit silly
>> > to use _ARRAY for something which is clearly meant to be a single item.
>> 
>> You are not alone.  I updated Réne's coccinelle rules to refrain
>> from converting xcalloc() to CALLOC_ARRAY() for a single element
>> case exactly because it feels silly to use array function for a
>> singleton with 1c57cc70 (cocci: allow xcalloc(1, size), 2021-03-15).
>
> OK. Then I'll leave it as-is, then. :)
>
> -Peff

I do not think any "huh? array for a singleton" folks mind your

  #define CALLOC(x) CALLOC_ARRAY((x), 1)

though ;-)