Re: [PATCH 0/9] ci: make Git's GitHub workflow output much more helpful

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 1, 2022, 16:57 UTC
Message-ID: <xmqqee3lsj8q.fsf@gitster.g>
In-Reply-To: <nycvar.QRO.7.76.6.2203011109050.11118@tvgsbejvaqbjf.bet>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> Yes, that's because line 5520 is the header of that group. If you direct
> the reader to
> https://github.com/git/git/runs/5343133021?check_suite_focus=true#step:4:5674
> instead, it will get expanded.

Ah, that's a good trick to know. I presume 5674 can be any random line in the block that is hidden by default that I want the viewer to expand, right?

> If it would not get expanded, that would be a bug, but obviously not in my
> patch series.

Well, the choice to use a mechanism that has such a bug is made by this patch series. If "allowing users to easily exchange a URL that points the exact place that the tests broke" were one of the goals, it does not matter whose fault it is---the aggregate result is that the new UI would have failed that goal.

Thankfully there does not seem to be such a bug in the UI mechanism used by this series, so we are in good shape.

Thanks.