Re: [PATCH 4/9] ci/run-build-and-tests: add some structure to the GitHub workflow output
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Feb 25, 2022, 13:40 UTC
- Message-ID
- <nycvar.QRO.7.76.6.2202251439160.11118@tvgsbejvaqbjf.bet>
- In-Reply-To
- <f73586a9-e9f1-aa1d-ac22-8102e6583e2b@gmail.com>
Hi Phillip,
On Wed, 23 Feb 2022, Phillip Wood wrote:
Show 12 quoted lines
> On 24/01/2022 18:56, Johannes Schindelin via GitGitGadget wrote: > > > +# Set 'exit on error' for all CI scripts to let the caller know that > > +# something went wrong. > > +# Set tracing executed commands, primarily setting environment variables > > +# and installing dependencies. > > +set -e > > The comment is moved unchanged but the set command has lost the "-x". We now > have several "set -x" commands in the functions above and one below > "end_group" lower down. Does the comment need updating as we are not enabling > the tracing of executed commands here anymore?
Oh yes, the comment needs to be updated. Thank you for pointing that out.
Ciao, Dscho