Re: [PATCH 01/16] packfile: introduce a new `struct packfile_store`
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 19, 2025, 17:32 UTC
- Message-ID
- <xmqqect7dxp7.fsf@gitster.g>
- In-Reply-To
- <20250819-b4-pks-packfiles-store-v1-1-1660842e125a@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
> memset(o, 0, sizeof(*o)); > o->repo = repo; > + o->packfiles = packfile_store_new(o);
Shouldn't this be called o->packfile_store? It is not like a packfile_store is merely an array of packfile struct, is it?
Show 5 quoted lines
> @@ -128,6 +129,7 @@ struct object_database {
> *
> * should only be accessed directly by packfile.c
> */
> + struct packfile_store *packfiles;So odb has a pointer to packfile_store, which in turn has a pointer to a(nother) odb?
Hmph. It is unclear what this step has achieved (in other words, there is no obvious thing that the information stored in the new structure is used to achieve at this step). Let me read on.
Thanks.