Re: [PATCH 01/16] packfile: introduce a new `struct packfile_store`
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Aug 20, 2025, 04:58 UTC
- Message-ID
- <aKVV6fuLuQnOoUoc@pks.im>
- In-Reply-To
- <CAOLa=ZTd3JTfkkxuuD51CbvJH1B+ag56LWKCgD55AzmWvi4XhA@mail.gmail.com>
On Tue, Aug 19, 2025 at 02:47:32AM -0700, Karthik Nayak wrote:
Show 15 quoted lines
> Patrick Steinhardt <ps@pks.im> writes:
> > diff --git a/odb.h b/odb.h
> > index 3dfc66d75a..026ba9386d 100644
> > --- a/odb.h
> > +++ b/odb.h
> > @@ -128,6 +129,7 @@ struct object_database {
> > *
> > * should only be accessed directly by packfile.c
> > */
> > + struct packfile_store *packfiles;
> >
>
> Nit: The newline spacing makes it seem like the comment above only
> applies to `struct packfile_store` while actually it also applies to
> `struct packed_git`.Fair. The remaining structs will go away over subsequent commits anyway, but we can still make this more obvious in this first step.
Patrick