Re: [PATCH v5 01/15] packfile: introduce a new `struct packfile_store`
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Sep 23, 2025, 09:34 UTC
- Message-ID
- <aNJpw1uJuhmpsCQ9@pks.im>
- In-Reply-To
- <hez25mocjub4zswsptv4j5etgygavllfai6zb6h2tdln2xhmo6@kjvvzrbjmilc>
On Wed, Sep 17, 2025 at 04:26:52PM -0500, Justin Tobler wrote:
Show 10 quoted lines
> On 25/09/15 10:54AM, Patrick Steinhardt wrote:
> > @@ -91,6 +91,7 @@ struct odb_source {
> > };
> >
> > struct packed_git;
> > +struct packfile_store;
>
> I find it a bit suprising that we already add a `struct packfile_store`
> to `struct odb_source` since it doesn't get wired up yet. I suppose it's
> just acting as a placeholder for what's to come though.You're probably misreading this: we don't add it to `struct odb_source`. This is only a forward declaration so that we can include the struct in `struct object_database`, which happens in this same commit.
Patrick