Re: [PATCH 06/16] odb: move kept cache into `struct packfile_store`

From: Patrick Steinhardt <ps@pks.im>
Date: Aug 20, 2025, 04:58 UTC
Message-ID: <aKVWB0YAJlhbEUe8@pks.im>
In-Reply-To: <xmqq8qjfdts9.fsf@gitster.g>

On Tue, Aug 19, 2025 at 11:56:54AM -0700, Junio C Hamano wrote:

Show 18 quoted lines

> Patrick Steinhardt <ps@pks.im> writes:
> > diff --git a/odb.h b/odb.h
> > index 2dc3bdc79d..f1736b067c 100644
> > --- a/odb.h
> > +++ b/odb.h
> > @@ -124,17 +124,10 @@ struct object_database {
> >  	unsigned commit_graph_attempted : 1; /* if loading has been attempted */
> >  
> >  	/*
> > -	 * private data
> > -	 *
> > -	 * should only be accessed directly by packfile.c
> > +	 * Should only be accessed directly by packfile.c
> >  	 */
> 
> Hmph, would this be better done in the step [01/16]?  Or did the
> removal of kept_pack_cache make the last piece of "private data"
> disappear with this step?

Yeah, the latter. All packfile-related private data is now encapsulated in `struct packfile_store`, so I felt like the comment became redundant with this commit here.

I'll mention this in the commit message.

Patrick