Re: [PATCH 03/16] odb: move initialization bit into `struct packfile_store`

From: Patrick Steinhardt <ps@pks.im>
Date: Aug 20, 2025, 04:58 UTC
Message-ID: <aKVV-pycfcXgwMit@pks.im>
In-Reply-To: <CAOLa=ZS4vBPp=2=X98DwEk48qgFMHvM4BecUPayGAK1Wasd3=A@mail.gmail.com>

On Tue, Aug 19, 2025 at 02:57:54AM -0700, Karthik Nayak wrote:

Show 25 quoted lines

> Patrick Steinhardt <ps@pks.im> writes:
> 
> > diff --git a/packfile.h b/packfile.h
> > index 1404b80917..573564b19e 100644
> > --- a/packfile.h
> > +++ b/packfile.h
> > @@ -64,6 +64,12 @@ struct packfile_store {
> >  	 * list.
> >  	 */
> >  	struct packed_git *packs;
> > +
> > +	/*
> > +	 * Whether packfiles have already been populated with this store's
> > +	 * packs.
> > +	 */
> > +	unsigned initialized : 1;
> >  };
> >
> 
> Nit: I know this is moved from existing code, but might be nice to
> adhere to our format rules here and remove spaces around the bit field.
> 
> Tangent: Also this is something that is only mentioned in the
> '.clang-format' but not in any of our documentation, should we add it to
> the documentation? Usage seems to be around the same for both types.

Well, now that booleans are allowed I think we should just stop using width specifiers like this altogether and instead use bool. There's probably still going to be cases where we use those, but I assume that the majority of users of this syntax is for flags.

Patrick