Re: [PATCH 1/6] t0080: move expected output to a file

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 1, 2024, 23:38 UTC
Message-ID: <xmqqcynwu1h6.fsf@gitster.g>
In-Reply-To: <20240701221019.GA20683@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 17 quoted lines

> On Mon, Jul 01, 2024 at 12:17:11PM -0700, Junio C Hamano wrote:
>
>> > But I do have such an "EOT" patch which I've been meaning to send out,
>> > since it makes many of these quoting annoyances go away (though of
>> > course it leaves the indentation).
>> 
>> I am not sure about your "test body comes from the standard input"
>> (not saying "I am not convinced it is a good idea" or even "I am
>> convinced it is a bad idea"---I do not know what to think about it,
>> not just yet).  THe above illustration does make it easier to grok
>> by keeping everything in one place.
>
> I just (re-)posted it in:
>
>   https://lore.kernel.org/git/20240701220815.GA20293@coredump.intra.peff.net/
>
> so you can see the improvement in some other real cases.

;-)

The shells we care about (and that does not include the /bin/sh on ancient Solaris ☹) should be OK, but "IFS= read -r line" somehow makes me feel nervous. Maybe I am superstitious.

Both steps look quite good.  Will queue.

Thanks.