Re: [PATCH 3/6] t-ctype: use TEST_RUN

From: René Scharfe <l.s.r@web.de>
Date: Jul 1, 2024, 20:04 UTC
Message-ID: <1a9c7351-68c2-4f2a-b00f-b4c8422ebe08@web.de>
In-Reply-To: <eh556xjlxipeyumm3gchiiggyogpcuznil5kwvudcpyecj4uxq@uy5tk66blzsl>

Am 01.07.24 um 21:49 schrieb Josh Steadmon:

Show 8 quoted lines

> On 2024.06.29 17:44, René Scharfe wrote:
>> Use the macro TEST_RUN instead of the internal functions
>> test__run_begin() and test__run_end().
>>
>> Signed-off-by: René Scharfe <l.s.r@web.de>
>
> Nitpick: please expand the commit message here as you did for the
> following patches.

There is not much more to it: Use of internal functions is discouraged, so this patch replaces their calls with the new public feature. Perhaps a "Kinda-requested-by: Phillip Wood <phillip.wood@dunelm.org.uk>" would be appropriate?

Unlike in the later patches the tests themselves are unchanged, so this has no consequence for people that want to add or modify character classifier tests.

René