Re: [PATCH 3/6] t-ctype: use TEST_RUN

From: René Scharfe <l.s.r@web.de>
Date: Jul 2, 2024, 20:55 UTC
Message-ID: <a0fdf91d-ebbd-4391-8076-f2805e083e1f@web.de>
In-Reply-To: <eae0ccf4-8747-400c-96ab-b7fc7a51beb9@gmail.com>

Am 02.07.24 um 17:14 schrieb phillip.wood123@gmail.com:

Show 24 quoted lines

> Hi René
>
> On 01/07/2024 21:04, René Scharfe wrote:
>> Am 01.07.24 um 21:49 schrieb Josh Steadmon:
>>> On 2024.06.29 17:44, René Scharfe wrote:
>>>> Use the macro TEST_RUN instead of the internal functions
>>>> test__run_begin() and test__run_end().
>>>>
>>>> Signed-off-by: René Scharfe <l.s.r@web.de>
>>>
>>> Nitpick: please expand the commit message here as you did for the
>>> following patches.
>>
>> There is not much more to it: Use of internal functions is discouraged,
>> so this patch replaces their calls with the new public feature.  Perhaps
>> a "Kinda-requested-by: Phillip Wood <phillip.wood@dunelm.org.uk>" would
>> be appropriate?
>
> Perhaps something like
>
> These tests use the internal functions test__run_begin() and
> test__run_end() which are supposed to be private to the test
> framework. Convert them to use the newly added TEST_RUN() instead.
> would be sufficient?

That works for me.

René