Re: [PATCH v2 1/8] refs/reftable: encapsulate reftable stack

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 12, 2024, 06:07 UTC
Message-ID: <xmqqcyj16l3k.fsf@gitster.g>
In-Reply-To: <ac01c06c4177d1b07678972115648d125c2bdc66.1730792627.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 5 quoted lines

> +static void reftable_backend_release(struct reftable_backend *be)
> +{
> +	reftable_stack_destroy(be->stack);
> +	be->stack = NULL;
> +}

OK, this turned out to be the required reading for the remainder of the patch ;-). Everything else was pretty much a mechanical replacement from reftable_stack to reftable_backend, but to get rid of the latter, we need to do this _release() thing where we used to do the _destroy on a bare reftable_stack instance.

Looking good and understandable.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.