[PATCH 6/8] reftable/stack: add mechanism to notify callers on reload
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Nov 4, 2024, 15:11 UTC
- Message-ID
- <0a294b577f915ccc901c6cd5e04f05ef24f34b15.1730732881.git.ps@pks.im>
- In-Reply-To
- <cover.1730732881.git.ps@pks.im>
Reftable stacks are reloaded in two cases:
- When calling `reftable_stack_reload()`, if the stat-cache tells us
that the stack has been modified.- When committing a reftable addition.
While callers can figure out the second case, they do not have a mechanism to figure out whether `reftable_stack_reload()` led to an actual reload of the on-disk data. All they can do is thus to assume that data is always being reloaded in that case.
Improve the situation by introducing a new `on_reload()` callback to the reftable options. If provided, the function will be invoked every time the stack has indeed been reloaded. This allows callers to invalidate data that depends on the current stack data.
Signed-off-by: Patrick Steinhardt <ps@pks.im> --- reftable/reftable-writer.h | 9 +++++++++ reftable/stack.c | 4 ++++ 2 files changed, 13 insertions(+)
diff --git a/reftable/reftable-writer.h b/reftable/reftable-writer.h index e4fc953788..d027f7070b 100644 --- a/reftable/reftable-writer.h +++ b/reftable/reftable-writer.h @@ -62,6 +62,15 @@ struct reftable_write_options { * negative value will cause us to block indefinitely. */ long lock_timeout_ms; + + /* + * Callback function to execute whenever the stack is being reloaded. + * This can be used e.g. to discard cached information that relies on + * the old stack's data. The payload data will be passed as argument to + * the callback. + */ + void (*on_reload)(void *payload); + void *on_reload_payload; }; /* reftable_block_stats holds statistics for a single block type */ diff --git a/reftable/stack.c b/reftable/stack.c index 530ba2d927..f943fc5b85 100644 --- a/reftable/stack.c +++ b/reftable/stack.c @@ -539,6 +539,10 @@ static int reftable_stack_reload_maybe_reuse(struct reftable_stack *st, close(fd); free_names(names); free_names(names_after); + + if (st->opts.on_reload) + st->opts.on_reload(st->opts.on_reload_payload); + return err; }
-- 2.47.0.229.g8f8d6eee53.dirty