From: Junio C Hamano Date: Tue, 12 Nov 2024 06:07:43 GMT Subject: Re: [PATCH v2 1/8] refs/reftable: encapsulate reftable stack Message-ID: In-Reply-To: Patrick Steinhardt writes: > +static void reftable_backend_release(struct reftable_backend *be) > +{ > + reftable_stack_destroy(be->stack); > + be->stack = NULL; > +} OK, this turned out to be the required reading for the remainder of the patch ;-). Everything else was pretty much a mechanical replacement from reftable_stack to reftable_backend, but to get rid of the latter, we need to do this _release() thing where we used to do the _destroy on a bare reftable_stack instance. Looking good and understandable.