Re: [PATCH v3 4/9] refs/reftable: read references via `struct reftable_backend`

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 26, 2024, 00:48 UTC
Message-ID: <xmqq34je4y6m.fsf@gitster.g>
In-Reply-To: <20241125-pks-reftable-backend-reuse-iter-v3-4-1d7b658e3e9e@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> Refactor `read_ref_without_reload()` to accept a `struct reftable_stack`
> as input instead of accepting a `struct reftable_stack`.

Hmph... am I supposed to be puzzled that the patch replaces A with A?

All callers of read_ref_without_reload() now call reftable_backend_read_ref().

The former took <reftable_ref_store, reftable_stack> while the latter take <reftable_backend>. They both take <refname, oid, referent, type>, of course, because the former is replaced by the latter.

OK, so we introduce a new function, and instead of passing ref-store and stack, the new function only takes reftable-backend (which has a stack contained in it).

The old function used ref-store only to find out the hash algorithm via its base repository. Since the hash algorithm can be found from the stack that is in the backend, the new function does not take a ref-store. FWIW, the old function did not have to take one either, but since we are getting rid of the old function altogether, that is fine ;-)

> This allows us
> to implement an additional caching layer when reading refs where we can
> reuse reftable iterators.

OK.