Re: [PATCH 3/8] refs/reftable: read references via `struct reftable_backend`

From: karthik nayak <karthik.188@gmail.com>
Date: Nov 5, 2024, 11:20 UTC
Message-ID: <CAOLa=ZRO_F93DDZefForD4Jx-ReXDKBnHeL8yOkHwPNtJ6S_bQ@mail.gmail.com>
In-Reply-To: <00fdf392a64f2b0f2e9bb7b398565a87c2e187b5.1730732881.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> Refactor `read_ref_without_reload()` to accept a `struct reftable_stack`

Do you mean `struct reftable_backend` here?

> as input instead of accepting a `struct reftable_stack`. This allows us
> to implement an additional caching layer when reading refs where we can
> reuse reftable iterators.
>

Nit: This commit also refactors the function to use the newly defined
'REFTABLE_HASH_*'. Maybe worth mentioning in the commit.

The patch itself looks good!

[snip]

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.