git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] checkout-index.c: Unconditionally free memory

From
Junio C Hamano <gitster@pobox.com>
Date
May 3, 2015, 03:03 UTC
Message-ID
<xmqqbni2wefo.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20150503023024.GA4269@peff.net>
Jeff King <peff@peff.net> writes:
Show 5 quoted lines
>> Sure, the prefix could even be "prefix_path(): $message", I would
>> think.
>
> I almost suggested that, but it not a change to prefix_path at all, but
> rather to its callers. That may be getting nit-picky, though. :)

Using "prefix_path(): free returned memory in the callers" as the title, with the body that explains that an earlier fix to make that a requirement but forgot to do so for a few that are fixed in this commit, would be sensible, no? It is not about how prefix_path() is implemented but its returned value, which is still about that function.

Previous: Jeff KingNext: Eric Sunshine
Message 11 of 12 in “checkout-index.c: Unconditionally free memory”
  1. checkout-index.c: Unconditionally free memoryStefan Beller, May 1, 2015
  2. Eric SunshineMay 1, 2015
  3. Eric SunshineMay 1, 2015
  4. Jeff KingMay 1, 2015
  5. Stefan BellerMay 1, 2015
  6. Jeff KingMay 1, 2015
  7. checkout-index.c: Unconditionally free memoryStefan Beller, May 1, 2015
  8. Jeff KingMay 1, 2015
  9. Junio C HamanoMay 3, 2015
  10. Jeff KingMay 3, 2015
  11. Junio C HamanoMay 3, 2015
  12. Eric SunshineMay 1, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.