Re: [PATCH] checkout-index.c: Unconditionally free memory
- From
Jeff King <peff@peff.net>
- Date
- May 1, 2015, 22:43 UTC
- Message-ID
- <20150501224334.GB1179@peff.net>
- In-Reply-To
- <1430519737-6224-1-git-send-email-sbeller@google.com>
On Fri, May 01, 2015 at 03:35:37PM -0700, Stefan Beller wrote:
> Subject: Re: [PATCH] checkout-index.c: Unconditionally free memory
Looks like the patch has expanded beyond checkout-index.c. Maybe:
unconditionally free result of prefix_path
would be more descriptive? I usually like the "area:" prefix, but I think here the common thread is not an area, but that they are return values from prefix_path.
Show 11 quoted lines
> diff --git a/builtin/checkout-index.c b/builtin/checkout-index.c
> index 9ca2da1..5325f92 100644
> --- a/builtin/checkout-index.c
> +++ b/builtin/checkout-index.c
> @@ -249,8 +249,7 @@ int cmd_checkout_index(int argc, const char **argv, const char *prefix)
> die("git checkout-index: don't mix '--stdin' and explicit filenames");
> p = prefix_path(prefix, prefix_length, arg);
> checkout_file(p, prefix);
> - if (p < arg || p > arg + strlen(arg))
> - free((char *)p);
> + free((char *)p);Can we just drop the "const" from the declaration of "p"? Then we don't have to do this funny cast here. It looks like the same applies to the other callsites, and even the other uses of prefix_path in update-index.c.
-Peff