From: Junio C Hamano Date: Sun, 03 May 2015 03:03:07 GMT Subject: Re: [PATCH] checkout-index.c: Unconditionally free memory Message-ID: In-Reply-To: <20150503023024.GA4269@peff.net> Jeff King writes: >> Sure, the prefix could even be "prefix_path(): $message", I would >> think. > > I almost suggested that, but it not a change to prefix_path at all, but > rather to its callers. That may be getting nit-picky, though. :) Using "prefix_path(): free returned memory in the callers" as the title, with the body that explains that an earlier fix to make that a requirement but forgot to do so for a few that are fixed in this commit, would be sensible, no? It is not about how prefix_path() is implemented but its returned value, which is still about that function.