git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] checkout-index.c: Unconditionally free memory

From
Jeff King <peff@peff.net>
Date
May 3, 2015, 02:30 UTC
Message-ID
<20150503023024.GA4269@peff.net>
In-Reply-To
<xmqqpp6iwgnn.fsf@gitster.dls.corp.google.com>
On Sat, May 02, 2015 at 07:15:08PM -0700, Junio C Hamano wrote:
Show 16 quoted lines
> Jeff King <peff@peff.net> writes:
> 
> > On Fri, May 01, 2015 at 03:35:37PM -0700, Stefan Beller wrote:
> >
> >> Subject: Re: [PATCH] checkout-index.c: Unconditionally free memory
> >
> > Looks like the patch has expanded beyond checkout-index.c. Maybe:
> >
> >   unconditionally free result of prefix_path
> >
> > would be more descriptive? I usually like the "area:" prefix, but I
> > think here the common thread is not an area, but that they are return
> > values from prefix_path.
> 
> Sure, the prefix could even be "prefix_path(): $message", I would
> think.

I almost suggested that, but it not a change to prefix_path at all, but rather to its callers. That may be getting nit-picky, though. :)

-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 10 of 12 in “checkout-index.c: Unconditionally free memory”
  1. checkout-index.c: Unconditionally free memoryStefan Beller, May 1, 2015
  2. Eric SunshineMay 1, 2015
  3. Eric SunshineMay 1, 2015
  4. Jeff KingMay 1, 2015
  5. Stefan BellerMay 1, 2015
  6. Jeff KingMay 1, 2015
  7. checkout-index.c: Unconditionally free memoryStefan Beller, May 1, 2015
  8. Jeff KingMay 1, 2015
  9. Junio C HamanoMay 3, 2015
  10. Jeff KingMay 3, 2015
  11. Junio C HamanoMay 3, 2015
  12. Eric SunshineMay 1, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.