git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] checkout-index.c: Unconditionally free memory

From
Jeff King <peff@peff.net>
Date
May 1, 2015, 22:39 UTC
Message-ID
<20150501223913.GA1179@peff.net>
In-Reply-To
<CAGZ79kYNR6JNU=vVL_Pp0axFX_cpu1Bi5x226GUbeFdum9wkZg@mail.gmail.com>
On Fri, May 01, 2015 at 03:33:13PM -0700, Stefan Beller wrote:
Show 8 quoted lines
> > Probably all of the other sites touched by be65e7d could use the same
> > treatment.
> 
> I looked around, just as Eric suggested as well and found those too.
> I don't think I'll track down the history of when this change became possible,
> but I'd rather point to (f5114a40c0d0, 2011-08-04, git-check-attr:
> Normalize paths),
> where the result of prefix_path is freed unconditionally already.

Ah, right. I noticed there were two extras in be65e7d that Eric hadn't mentioned, but I didn't actually check to see if they were already fixed. It looks like they are (further evidence that this is a good thing to be doing :) ).

-Peff
Previous: Stefan BellerNext: Stefan Beller
Message 6 of 12 in “checkout-index.c: Unconditionally free memory”
  1. checkout-index.c: Unconditionally free memoryStefan Beller, May 1, 2015
  2. Eric SunshineMay 1, 2015
  3. Eric SunshineMay 1, 2015
  4. Jeff KingMay 1, 2015
  5. Stefan BellerMay 1, 2015
  6. Jeff KingMay 1, 2015
  7. checkout-index.c: Unconditionally free memoryStefan Beller, May 1, 2015
  8. Jeff KingMay 1, 2015
  9. Junio C HamanoMay 3, 2015
  10. Jeff KingMay 3, 2015
  11. Junio C HamanoMay 3, 2015
  12. Eric SunshineMay 1, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.