Re: [PATCH v8 00/11] Git filter protocol
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 29, 2016, 21:19 UTC
- Message-ID
- <xmqqa8eqe746.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20160929180247.d4owhzwyawtanw3r@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 13 quoted lines
> I don't necessarily agree, though, that the timing of filter-process > cleanup needs to be part of the public interface. So in your list: > >> 3) Git waits until the filter process finishes. > > That seems simple and elegant, but I can think of reasons we might not > want to wait (e.g., if the filter has to do some maintenance task and > does not the user to have to wait). > > OTOH, we already face this in git, and we solve it by explicitly > backgrounding the maintenance task (i.e., auto-gc). So one could argue > that it is the responsibility of the filter process to manage its own > processes. It certainly makes the interaction with git simpler.
Yup, that summarizes my thinking a lot better than I managed to do in the previous message.