Re: [PATCH v8 03/11] run-command: move check_pipe() from write_or_die to run_command

From: Jakub Narębski <jnareb@gmail.com>
Date: Sep 26, 2016, 16:21 UTC
Message-ID: <CANQwDwd7YMjoyO3Y=FqcX720_vcqa0L=z6veTgYO==LorhqqFQ@mail.gmail.com>
In-Reply-To: <4B4255C0-4C0C-45F0-B37D-0C78C2AAFAE9@gmail.com>

On 26 September 2016 at 18:13, Lars Schneider <larsxschneider@gmail.com> wrote:

Show 10 quoted lines

>> On 25 Sep 2016, at 00:12, Jakub Narębski <jnareb@gmail.com> wrote:
>> W dniu 20.09.2016 o 21:02, larsxschneider@gmail.com pisze:
>>> From: Lars Schneider <larsxschneider@gmail.com>
>>>
>>> Move check_pipe() to run_command and make it public. This is necessary
>>> to call the function from pkt-line in a subsequent patch.
>>
>> All right.
>
> Does this mean I can add your "Acked-by: Jakub Narebski <jnareb@gmail.com>" ?

Well, Acked-by makes sense if it is from subsystem maintainer. I can only claim gitweb subsystem where my ACKs might make sense.

This "All right" is here to note that I have read this patch (and not skipped it), and I have't found anything to complain about or nitpick ;-P

Best,

-- 
Jakub Narębski