Re: [PATCH v8 03/11] run-command: move check_pipe() from write_or_die to run_command

From: Jakub Narębski <jnareb@gmail.com>
Date: Sep 24, 2016, 22:12 UTC
Message-ID: <854ff387-57a4-4c27-4c27-b834f7797694@gmail.com>
In-Reply-To: <20160920190247.82189-4-larsxschneider@gmail.com>

W dniu 20.09.2016 o 21:02, larsxschneider@gmail.com pisze:

> From: Lars Schneider <larsxschneider@gmail.com>
> 
> Move check_pipe() to run_command and make it public. This is necessary
> to call the function from pkt-line in a subsequent patch.

All right.

Show 7 quoted lines

> 
> Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
> ---
>  run-command.c  | 13 +++++++++++++
>  run-command.h  |  2 ++
>  write_or_die.c | 13 -------------
>  3 files changed, 15 insertions(+), 13 deletions(-)

Diffstat looks correct.

Not to add to your burden, but perhaps somebody could add to his/her TODO documenting check_pipe() in Documentation/technical/api-run-command.txt Or is it not worth it?

Best regards,

-- 
Jakub Narębski