Re: [PATCH v8 11/11] convert: add filter.<driver>.process option
Show 14 quoted lines
> On 04 Oct 2016, at 22:50, Jakub Narębski <jnareb@gmail.com> wrote:
>
> [Some of answers may get invalidated by v9]
>
> W dniu 30.09.2016 o 20:56, Lars Schneider pisze:
>>> On 27 Sep 2016, at 00:41, Jakub Narębski <jnareb@gmail.com> wrote:
>>>
>>>> +
>>>> +After the filter has processed a blob it is expected to wait for
>>>> +the next "key=value" list containing a command. Git will close
>>>> +the command pipe on exit. The filter is expected to detect EOF
>>>> +and exit gracefully on its own.
>
> Is this still true?
Show 16 quoted lines
>>>
>>> Good to have it documented.
>>>
>>> Anyway, as it is Git command that spawns the filter driver process,
>>> assuming that the filter process doesn't daemonize itself, wouldn't
>>> the operating system reap it after its parent process, that is the
>>> git command it invoked, dies? So detecting EOF is good, but not
>>> strictly necessary for simple filter that do not need to free
>>> its resources, or can leave freeing resources to the operating
>>> system? But I may be wrong here.
>>
>> The filter process runs independent of Git.
>
> Ah. So without some way to tell long-lived filter process that
> it can shut down, because no further data will be incoming, or
> killing it by Git, it would hang indefinitely?