Re: [PATCH v3 02/10] submodule status: use submodule--helper is-active
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 14, 2017, 20:20 UTC
- Message-ID
- <xmqqa88nip9z.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <CAGZ79kZ6noz7RGbmNwg=NhuWYH=KbNPYUWL7We9YjbHn6uf2Jg@mail.gmail.com>
Stefan Beller <sbeller@google.com> writes:
Show 7 quoted lines
> There we take the path as name and if a real name exists, the name > is overwritten with the real name, i.e. > > name = name_for_path(path) ? name_for_path(path) : path; > > which IMHO is overly accepting and we should just die in case of > !name_for_path.
Yes, I agree that falling back (unless path is a submodule yet to be added to .gitmodules) is bad.