Re: [PATCH 10/10] submodule--helper clone: check for configured submodules using helper

From: Stefan Beller <sbeller@google.com>
Date: Feb 24, 2017, 00:58 UTC
Message-ID: <CAGZ79kYmmeVOYSPTvAbGpRQn1YL9yjPOkT5xCoSDmtNzQ1t2fw@mail.gmail.com>
In-Reply-To: <20170223234728.164111-11-bmwill@google.com>

On Thu, Feb 23, 2017 at 3:47 PM, Brandon Williams <bmwill@google.com> wrote:

Show 8 quoted lines

> @@ -795,14 +794,11 @@ static int prepare_to_clone_next_submodule(const struct cache_entry *ce,
>         }
>
>         /*
> -        * Looking up the url in .git/config.
> +        * Check if the submodule has been initialized.
>          * We must not fall back to .gitmodules as we only want
>          * to process configured submodules.

This sentence "we must not ..." is also no longer accurate, as we do exactly that when using sub->url instead of just url below.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.