Re: [PATCH 10/10] submodule--helper clone: check for configured submodules using helper
On 02/23, Stefan Beller wrote:
Show 14 quoted lines
> On Thu, Feb 23, 2017 at 3:47 PM, Brandon Williams <bmwill@google.com> wrote:
>
> > @@ -795,14 +794,11 @@ static int prepare_to_clone_next_submodule(const struct cache_entry *ce,
> > }
> >
> > /*
> > - * Looking up the url in .git/config.
> > + * Check if the submodule has been initialized.
> > * We must not fall back to .gitmodules as we only want
> > * to process configured submodules.
>
> This sentence "we must not ..." is also no longer accurate,
> as we do exactly that when using sub->url instead of just url
> below.
You're right, I'll fix that.
--
Brandon Williams