Re: Git for Windows v2.23.0-rc0, was Re: [ANNOUNCE] Git v2.23.0-rc0

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 1, 2019, 21:46 UTC
Message-ID: <xmqqa7csmudm.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190801213638.GA30522@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 6 quoted lines

>> +	if (mailmap < 0)
>>  		mailmap = 0;
>> -	}
>
> This should be "mailmap = 1" to match the commit message, no? (Which
> also implies we may want a new test).

Gaa, of course.

Show 5 quoted lines

> I'd also be OK with leaving it at "0" for now, making a note of the
> upcoming change in the release notes, and flipping it _next_ time. But
> IMHO we don't need to be that conservative (and I share your pessimism
> that enough people actually read the release notes to merit that kind of
> advance notice).

I'd actually think s/need to be/get any benefit from being/; it would be wasted effort to be extra careful, and any way we cut it, there will always be people who complain.