Re: Git for Windows v2.23.0-rc0, was Re: [ANNOUNCE] Git v2.23.0-rc0

From: Jeff King <peff@peff.net>
Date: Aug 2, 2019, 18:35 UTC
Message-ID: <20190802183529.GA26918@sigill.intra.peff.net>
In-Reply-To: <xmqqblx7ld98.fsf@gitster-ct.c.googlers.com>

On Fri, Aug 02, 2019 at 09:53:55AM -0700, Junio C Hamano wrote:

Show 10 quoted lines

> Jonathan Nieder <jrnieder@gmail.com> writes:
> 
> > We'll also want to update the docs.  And as Todd suggests, we should
> > cover how to disable mailmap in tests.
> >
> > Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
> > ---
> 
> I avoided the "don't bother initializing use_mailmap_config to
> unknown" simplification, but I guess the change is clear enough.

Yeah, I didn't even look to see if there were further simplifications possible, but seeing Jonathan's patch, it looks like an obvious improvement. And a quick grep shows that there are no other sites that should be affected by losing the "-1" semantics, so I think it's a good idea.

And of course the doc and test improvements are very welcome. :)

-Peff