Re: Git for Windows v2.23.0-rc0, was Re: [ANNOUNCE] Git v2.23.0-rc0

From: Jeff King <peff@peff.net>
Date: Jul 31, 2019, 23:18 UTC
Message-ID: <20190731231848.GC1933@sigill.intra.peff.net>
In-Reply-To: <nycvar.QRO.7.76.6.1907311440130.21907@tvgsbejvaqbjf.bet>

On Wed, Jul 31, 2019 at 02:43:10PM +0200, Johannes Schindelin wrote:

Show 12 quoted lines

> And a corresponding Git for Windows v2.23.0-rc0 can be found here:
> 
> https://github.com/git-for-windows/git/releases/tag/v2.23.0-rc0.windows.1
> 
> Please test!
> 
> One (slightly annoying) issue I found already is that a `git log` will
> print out a blurb about `log.mailmap`, but most of the time, you cannot
> see it because the actual output of `git log` is shown in the pager.
> 
> I plan on working around this by setting `log.mailmap = true` in Git for
> Windows' system config.

I too was annoyed recently by that warning (I set the config to squelch it, but I'm sure it will pop up again for me in some other context where I don't have my usual config).

Setting log.mailmap=true in the distributed system seems to defeat the purpose, though, doesn't it? The point is for users to see the warning and adjust their expectations, but with your plan they would never see it.

I think part of what my annoyance is responding to (and your willingness to just squelch this for everybody) is that switching this particular default isn't really that big a deal, that it requires annoying people on every single "git log" invocation. Perhaps we would be better squelching it entirely and just putting a mention in the release notes.

I know that having been burned by the dashed-form deprecation long ago, Junio is hesitant to rely on release notes. But it really seems like this is a pretty minor change, and the solution is worse than the problem.

-Peff