Re: Git for Windows v2.23.0-rc0, was Re: [ANNOUNCE] Git v2.23.0-rc0

From: Ariadne Conill <ariadne@dereferenced.org>
Date: Aug 1, 2019, 04:54 UTC
Message-ID: <CAAOiGNzzGqSYxhw=KACYRTxArCY+5H8M4UyY5LFdsnO5VehpOA@mail.gmail.com>
In-Reply-To: <xmqqsgqlo9j6.fsf@gitster-ct.c.googlers.com>

Hello,

On Wed, Jul 31, 2019 at 10:21 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 23 quoted lines

>
> Jeff King <peff@peff.net> writes:
>
> > This seems OK to me, though I kind of wonder if anybody really wants
> > "auto". Unlike log.decorate, which changes the syntax, there is no real
> > reason to avoid mailmap when somebody else is parsing the output. And I
> > could imagine it is especially confusing if:
> >
> >   git log --author=whoever
> >
> > and
> >
> >   git log | grep whoever | wc -l
> >
> > do not agree.
>
> I personally do not think it is too late to change for the upcoming
> release, either.
>
> But 'auto' that changes the displayed name depending on the output
> being or not being a terminal makes little sense, I would think, for
> the above reason.
>

I think if the warning is annoying people, then we should just change the default and document it in the release notes. Ultimately, I think that this is behaviour that most see as a bug (especially when you consider that `git shortlog` and `git blame` default to using mailmap already), so simply describing it as a bugfix is arguably sufficient.

Ariadne