git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Git for Windows v2.23.0-rc0, was Re: [ANNOUNCE] Git v2.23.0-rc0

From
Jeff King <peff@peff.net>
Date
Aug 1, 2019, 21:36 UTC
Message-ID
<20190801213638.GA30522@sigill.intra.peff.net>
In-Reply-To
<xmqqlfwcopn1.fsf@gitster-ct.c.googlers.com>
On Thu, Aug 01, 2019 at 08:45:54AM -0700, Junio C Hamano wrote:
Show 9 quoted lines
> While I think "revert to hardcoded default" may be a good idea, I do
> not think the hardcoded default you implemented that changes the
> behaviour based on the output destination makes much sense.  If I
> want to eradicate junkio@cox.net from my paged/interactive output, I
> want to eradicate it also in the output piped to the script I use
> for authorship stats.  
> 
> I suspect that you may have misread the "is interactive" bit in the
> original; that was used only to decide if we are going to warn.
Yeah, I wondered about the same misreading when I read the response in:
  https://public-inbox.org/git/20190801011448.GB176307@google.com/
> Anyway, how about this much simplified version?
Yes, this is what I was thinking of in my earlier responses, but...
Show 11 quoted lines
> @@ -214,12 +204,8 @@ static void cmd_log_init_finish(int argc, const char **argv, const char *prefix,
>  	memset(&w, 0, sizeof(w));
>  	userformat_find_requirements(NULL, &w);
>  
> -	if (mailmap < 0) {
> -		if (session_is_interactive() && !rev->pretty_given)
> -			warning("%s\n", _(warn_unspecified_mailmap_msg));
> -
> +	if (mailmap < 0)
>  		mailmap = 0;
> -	}

This should be "mailmap = 1" to match the commit message, no? (Which also implies we may want a new test).

I'd also be OK with leaving it at "0" for now, making a note of the upcoming change in the release notes, and flipping it _next_ time. But IMHO we don't need to be that conservative (and I share your pessimism that enough people actually read the release notes to merit that kind of advance notice).

-Peff
Previous: Ariadne ConillNext: Junio C Hamano
Message 15 of 27 in “[ANNOUNCE] Git v2.23.0-rc0”
  1. Junio C HamanoJul 29, 2019
  2. Git for Windows v2.23.0-rc0, was Re: [ANNOUNCE] Git v2.23.0-rc0Johannes Schindelin, Jul 31, 2019
  3. Jeff KingJul 31, 2019
  4. Jonathan NiederAug 1, 2019
  5. Ariadne ConillAug 1, 2019
  6. Jeff KingAug 1, 2019
  7. Jonathan NiederAug 1, 2019
  8. Ariadne ConillAug 1, 2019
  9. Jeff KingAug 1, 2019
  10. Junio C HamanoAug 1, 2019
  11. Ariadne ConillAug 1, 2019
  12. Johannes SchindelinAug 1, 2019
  13. Junio C HamanoAug 1, 2019
  14. Ariadne ConillAug 1, 2019
  15. Jeff KingAug 1, 2019
  16. Junio C HamanoAug 1, 2019
  17. Junio C HamanoAug 1, 2019
  18. Todd ZullingerAug 1, 2019
  19. Jonathan NiederAug 2, 2019
  20. Junio C HamanoAug 2, 2019
  21. Jeff KingAug 2, 2019
  22. Bryan TurnerAug 1, 2019
  23. Johannes SchindelinAug 1, 2019
  24. RelNotes/2.23.0: fix a few typos and other minor issuesMartin Ågren, Aug 1, 2019
  25. Junio C HamanoAug 1, 2019
  26. Junio C HamanoAug 1, 2019
  27. Martin ÅgrenAug 1, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.