Re: [PATCH 2/4] editor: use standard strvec API to receive environment for external editors

From: Junio C Hamano <gitster@pobox.com>
Date: May 21, 2025, 15:10 UTC
Message-ID: <xmqqa576c83j.fsf@gitster.g>
In-Reply-To: <aC2HF1VEosDMY_A2@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 5 quoted lines

>> Signed-off-by: D. Ben Knoble <ben.knoble+github@gmail.com>
>> Helped-by: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> The order of these trailers should be reversed -- your SOB should always
> come last.

Yup. The intent is to record what happened before the patch was sent out with your sign-off chronologically. Dscho helped and then Ben finialized the patch by signing off, hence the author's sign-off comes the last.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.