Re: [PATCH 2/4] editor: use standard strvec API to receive environment for external editors

From: Patrick Steinhardt <ps@pks.im>
Date: May 21, 2025, 13:34 UTC
Message-ID: <aC3WSePH3-7jJk-5@pks.im>
In-Reply-To: <CALnO6CDGGiw2HJTjfhvnmLQpQYDJqQux7UdO1tv0c9-LqNXMxg@mail.gmail.com>

On Wed, May 21, 2025 at 09:26:50AM -0400, D. Ben Knoble wrote:

Show 11 quoted lines

> On Wed, May 21, 2025 at 3:56 AM Patrick Steinhardt <ps@pks.im> wrote:
> > > Signed-off-by: D. Ben Knoble <ben.knoble+github@gmail.com>
> > > Helped-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > The order of these trailers should be reversed -- your SOB should always
> > come last.
> 
> Thanks; I didn't know that! (Aside: rebase --signoff seems to add SOB
> even when it's already present. Is that a bug in rebase --signoff or a
> misuse of the trailer on my end? Setting "trailer.ifExists =
> addIfDifferent" didn't seem to affect it.)

git-rebase(1) assumes that your SOB comes last, so that's probably why it re-adds it :)

Patrick