Re: [PATCH 2/4] editor: use standard strvec API to receive environment for external editors

From: Patrick Steinhardt <ps@pks.im>
Date: May 21, 2025, 07:56 UTC
Message-ID: <aC2HF1VEosDMY_A2@pks.im>
In-Reply-To: <20250520193506.95199-3-ben.knoble+github@gmail.com>

On Tue, May 20, 2025 at 03:34:56PM -0400, D. Ben Knoble wrote:

Show 8 quoted lines

> Going back to the introduction of the env parameter for the editor in
> 8babab95af (builtin-commit.c: export GIT_INDEX_FILE for launch_editor as
> well., 2007-11-26), we pass a constant array of strings: as the
> surrounding APIs evolved to use strvecs, the editor code did not.
> 
> There is only one caller of all 3 editor APIs that does not pass a NULL
> environment (the same caller for which this parameter was added), and
> it already has a strvec available to use.

Okay. It would've been nice to explain _why_ we want to do this change, but the change itself looks sensible.

> Signed-off-by: D. Ben Knoble <ben.knoble+github@gmail.com>
> Helped-by: Johannes Schindelin <johannes.schindelin@gmx.de>

The order of these trailers should be reversed -- your SOB should always come last.

Patrick