Re: [PATCH v3 0/4] clean up some code around editors

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Aug 12, 2025, 00:16 UTC
Message-ID: <CAPig+cTpMFfg8iTncgekq6wyfHOPidhHposLi11D3fXyfnNQRw@mail.gmail.com>
In-Reply-To: <6BCA1E93-7409-41FA-81FB-0CB75A3A55FB@gmail.com>

On Mon, Aug 11, 2025 at 6:59 PM Ben Knoble <ben.knoble@gmail.com> wrote:

Show 7 quoted lines

> > Le 11 août 2025 à 18:17, D. Ben Knoble <ben.knoble+github@gmail.com> a écrit :
> > Changes from v2:
> > - shuffle setup code and use more helpers in 1/4
> > - insert 2/4 to stop abusing --exec-path
> > - improve environment-cleansing idioms in {2 => 3}/4
>
> Some of this shuffling turned out to be unportable, which CI caught (but running the test locally didn’t??). Fortunately it pointed me at test_env and I’ll either use it or go back to the subshells.

To catch it locally, you can run:

    make test-lint-shell-syntax

in the "t" directory. Alternatively, `make test-lint`, `make test` or `make prove` would also have caught the problem.