Re: [PATCH v3 0/4] clean up some code around editors

From: D. Ben Knoble <ben.knoble@gmail.com>
Date: Aug 12, 2025, 16:42 UTC
Message-ID: <CALnO6CApnHgakYf_ihVOxkmOq9_Rph5hkK_9aC6vrecFhgjaTA@mail.gmail.com>
In-Reply-To: <CAPig+cTpMFfg8iTncgekq6wyfHOPidhHposLi11D3fXyfnNQRw@mail.gmail.com>

On Mon, Aug 11, 2025 at 8:16 PM Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 16 quoted lines

>
> On Mon, Aug 11, 2025 at 6:59 PM Ben Knoble <ben.knoble@gmail.com> wrote:
> > > Le 11 août 2025 à 18:17, D. Ben Knoble <ben.knoble+github@gmail.com> a écrit :
> > > Changes from v2:
> > > - shuffle setup code and use more helpers in 1/4
> > > - insert 2/4 to stop abusing --exec-path
> > > - improve environment-cleansing idioms in {2 => 3}/4
> >
> > Some of this shuffling turned out to be unportable, which CI caught (but running the test locally didn’t??). Fortunately it pointed me at test_env and I’ll either use it or go back to the subshells.
>
> To catch it locally, you can run:
>
>     make test-lint-shell-syntax
>
> in the "t" directory. Alternatively, `make test-lint`, `make test` or
> `make prove` would also have caught the problem.

Ah, thanks. I was particularly confused because running the test file directly does run the chainlint check, I think, but not this lint.

-- 
D. Ben Knoble