Re: [PATCH v5 1/3] replay: add helper to put entry into mapped_commits
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 26, 2026, 16:50 UTC
- Message-ID
- <xmqqa4sh8cvr.fsf@gitster.g>
- In-Reply-To
- <20260626-toon-git-replay-drop-merges-v5-1-5e120738b9d0@iotcl.com>
Toon Claes <toon@iotcl.com> writes:
Show 10 quoted lines
> +static void put_mapped_commit(kh_oid_map_t *replayed_commits,
> + struct commit *commit,
> + struct commit *new_commit)
> +{
> + khint_t pos;
> + int ret;
> +
> + pos = kh_put_oid_map(replayed_commits, commit->object.oid, &ret);
> + if (ret == 0)
> + BUG("Duplicate rewritten commit: %s\n",Please do not add terminating LF at the end of single-liner messages that use our print infrastructure, like BUG(), warning(), error(), and die(), as the machinery adds one for you.
Other than that, looking good.