Re: [PATCH v2 1/3] replay: refactor enum replay_mode into a bool

From: Toon Claes <toon@iotcl.com>
Date: Jun 12, 2026, 08:19 UTC
Message-ID: <87h5n8yxur.fsf@emacs.iotcl.com>
In-Reply-To: <airORumUxyTsN7Bz@denethor>

Justin Tobler <jltobler@gmail.com> writes:

> Naive question: Do we expect there to only be two replay modes in the
> forseeable future? I suppose if other modes were added in the future
> this change would essentially be reverted.

The enum was mainly used to determine "direction": PICK to apply commits forward, and REVERT to apply them in opposite order. But it's a bit twofold, because REVERT also applies the inverse change. At the moment --onto and --advance use PICK and --revert uses REVERT. There could be added more options in the future, but I don't expect any of them to add a new mode. And if there is ever a new mode needed, I think it's better to re-add the enum then, or maybe a second bool makes sense then, who knows...

-- 
Cheers,
Toon